build: `windows-sys` 0.48.0 → 0.52.0

rust-windowing / glutin

A low-level library for OpenGL context creation

Apache License 2.0

1.98k stars 476 forks source link

build: `windows-sys` 0.48.0 → 0.52.0 #1680

Closed ErichDonGubler closed 3 months ago

ErichDonGubler commented 3 months ago

[x] Tested on all platforms changed
[x] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
[x] ~~Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior~~
[x] ~~Created or updated an example program if it would help users understand this functionality~~

MarijnS95 commented 3 months ago

What does build mean in the title? Isn't this part of the glutin runtime crate?

ErichDonGubler commented 3 months ago

@MarijnS95: Ah, that's a convention from certain communities that use Conventional Commits; this cheat sheet describes well how I've seen it used, which is:

Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)

I can alter or remove the prefix if you want. Just LMK!

MarijnS95 commented 3 months ago

I've never liked "conventional commits" for e.g. this reason. What does "build" have to do with "external dependencies"?

ErichDonGubler commented 3 months ago

I mean, Rust developers in particular quite literally cargo build dependencies into a binary. It doesn't sound conceptually distant to me, but I understand if you prefer a different prefix (or a system of authoring history outside of Conventional Commits).

My offer to change the commit message still stands.

kchibisov commented 3 months ago

Generally, the title prefix should reflect the subsystem, in this case it was primary wgl.