Closed varphone closed 2 months ago
Could you add a changelog entry for that? should be fine after that.
Already added, please review again.
In general I'm not a fan of "Fixed crash" or other context-less titles using the word "fix", can we come up with anything more descriptive (i.e. "use the correct calling convention for EglGetProcAddress()
on Win32-x86 (optionally: preventing a crash)")? Same for the PR title.
Probably not a requirement to merge though, depending on what Kirill thinks of this.
CHANGELOG.md
if knowledge of this change could be valuable to usersSummary
Change the calling convention of the
EglGetProcAddress
declaration toextern "system"
to automatically use the correct calling convention for the platform.Details
The
EglGetProcAddress
function uses thestdcall
calling convention on theWin32-x86
platform, but it was previously declared asextern "C"
in the code.On the
Win32-x86
platform,extern "C"
functions use thecdecl
calling convention by default.This mismatch in calling conventions caused a crash.
By changing the declaration to
extern "system"
, the correct calling convention for the platform will be used automatically, preventing the crash.Testing
Win32-x86
platform.