Open MarijnS95 opened 1 month ago
deep and heavy sigh
This is a breaking change, and should be combined with https://github.com/rust-windowing/raw-window-handle/pull/154
We can change them back to pointers. If they decide to go back to usize
just keep them as pointers.
Actually wait, does this impact us? From the issue linked above:
Rust currently emits isize/usize integers as a result of decomposing our synthetic handle types and encountering IntPtr/UIntPtr. Rust would now like to emit pointers to better align with its core handle type, but it cannot differentiate between legitimate pointer-sized integers (e.g. LRESULT) and handles (e.g. HMODULE).
Since window IDs in Windows are just indexes into a thread-local table, they're still semantically usize
/isize
. So it's still correct (by Rust's standards) to not change them here, even if win32metadata
doesn't realize it.
_Originally posted by @MarijnS95 in https://github.com/rust-windowing/raw-window-handle/pull/136#discussion_r1640368547_
This is out now in the
windows 0.58
release and somewhat annoying when usingraw-window-handle
together with it.