macOS: add option to explicitly hide menu/dock in Borderless

rust-windowing / winit

Window handling library in pure Rust

https://docs.rs/winit/

Apache License 2.0

4.89k stars 914 forks source link

macOS: add option to explicitly hide menu/dock in Borderless #3882

Closed TarekAS closed 2 months ago

TarekAS commented 3 months ago

Addresses #3880

[x] Tested on all platforms changed
[x] Added an entry to the changelog module if knowledge of this change could be valuable to users
[ ] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
[ ] Created or updated an example program if it would help users understand this functionality
[ ] Updated feature matrix, if new features were added or implemented

TarekAS commented 3 months ago

I tested cycling through the fullscreen modes while in fullscreen, seems like a broken experience either way and setting the borderless_game attribute doesn't change the current behavior from what I can tell. So we're fine there I guess.

I found a bug with this implementation though. The menu bar remains clickable despite being hidden, I'm puzzled why that's behaving like that.

This PR won't be ready to merge until I fix that issue

TarekAS commented 3 months ago

Fixed it by moving the presentation options to set_fullscreen. Tried everything to make it work in window:willUseFullScreenPresentationOptions but it's hella wonky.

Re-tested again, including cycling between fullscreen modes, and it works well. The menu bar is properly disabled when borderless_game is set.

TarekAS commented 2 months ago

Hi folks, any more work is needed on my part for this PR?