Update `smol_str` - Githubissues

rust-windowing / winit

Window handling library in pure Rust

https://docs.rs/winit/

Apache License 2.0

4.87k stars 910 forks source link

Update `smol_str` #3991

Open BenjaminBrienen opened 1 week ago

BenjaminBrienen commented 1 week ago

[x] Tested on all platforms changed
[x] Added an entry to the changelog module if knowledge of this change could be valuable to users
[x] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
[x] Created or updated an example program if it would help users understand this functionality
[x] Updated feature matrix, if new features were added or implemented

smol_str is part of the crate's API, which causes type mismatches that can't be resolved downstream.

kchibisov commented 1 week ago

Unless you use winit master this won't solve anything, and you can use as many crates as you want and cast things if you use newer version of smol_str.

I'm not against updating it now, I just want to get rid of it entirely in 0.31, and this can not be backported.

I don't mind temporary bumping on master though if someone needs it.

BenjaminBrienen commented 1 week ago

Well it has to be updated in master before it gets released, right? It's fine if it takes time. This is just the step to get the ball rolling.

edit: I see you want to remove it entirely in 0.31. You can just close this issue if this is not the direction winit is moving. Sorry!

kchibisov commented 1 week ago

Sure, I just tend to update all the deps closer to release date, so you don't update more than once during cycle.