rust-windowing / winit

Window handling library in pure Rust
https://docs.rs/winit/
Apache License 2.0
4.7k stars 886 forks source link

Wayland: Blurry cursor when using HiDPI scaling #727

Closed trbjo closed 4 years ago

trbjo commented 5 years ago

Perhaps this should be added to the "Wayland metabug" report?

Anyway, I use HiDPI scaling on Linux+Wayland+Sway, and alacritty's cursor it blurry. It has the correct size though, and the rest of the window (i.e. text rendering) is sharp enough.

It doesn't happen, when I turn scaling off.

I know QT apps had the same bug until version 5.12, so I'm quite certain it's a bug in winit.

The fix in QT can be found here: https://codereview.qt-project.org/#/c/225465/

elinorbgr commented 5 years ago

This is actually an issue with SCTK, but it'll likely require some work in winit too.

blocked on https://github.com/Smithay/client-toolkit/issues/47

illiliti commented 4 years ago

https://github.com/Smithay/client-toolkit/commit/d61c5517ff23b97d802927f7630452d4cff6a808

goddessfreya commented 4 years ago

Is this still a issue?

illiliti commented 4 years ago

Is this still a issue?

I can reproduce this on sway 1.4, alacritty 0.4.1

kchibisov commented 4 years ago

@goddessfreya this is an issue and I'm working on it right now. During more extensive testing with winit I've found out a very strange bug with HiDPI cursors. So I'm investigating right now.

So it'll likely be blocked until https://github.com/Smithay/client-toolkit/pull/97 will be answered and new 0.6.x release will arrive.

elinorbgr commented 4 years ago

Smithay/client-toolkit@d61c551

Note that this commit is only on SCTK 0.7.0, which significantly changed the API of the lib. Winit will need some work to be updated to this new version. I'll probably do it at some point when I get the time to unless someones attacks it before me.