search

rust-windows / wg

For discussion of all issues this working group takes up
8 stars 0 forks source link

Winapi maintenance #2

Open retep998 opened 4 years ago

retep998 commented 4 years ago

It would be nice to eventually migrate winapi here so the windows working group can take on maintenance of winapi together.

fkaa commented 4 years ago

Are there any steps to make this happen? (documenting the review process, how to release new version, etc.)

retep998 commented 4 years ago

Are there any steps to make this happen?

I don't know what I'm waiting on to make this happen.

documenting the review process

Compare the bindings side by side with the latest Windows SDK header to ensure accuracy. Ensure the PR follows the guidelines stated in CONTRIBUTING.md. Once there are sufficient approval reviews with no remaining mistakes to fix, the PR can be "Squash and Merge"d.

how to release new version

Something something wincheck. Ensure that every reverse dependency of winapi which built with the existing published version of winapi also builds with the new about to be published version. If there are no breakages then bump the version and publish.

etc.

???

ratijas commented 4 years ago

Something something wincheck. Ensure that every reverse dependency of winapi which built with the existing published version of winapi also builds with the new about to be published version. If there are no breakages then bump the version and publish.

How can crater help with this one?

https://github.com/rust-lang/crater

retep998 commented 4 years ago

@ratijas I've currently implemented functionality in https://github.com/retep998/wincheck to do that. It's not the most elegant solution but it gets the job done using nothing more than free Github Actions CI. If someone wants to improve it or provide a better solution than I am open to such changes.

retep998 commented 4 years ago

It appears that Github Actions has a limit of only 5 concurrent jobs for repos in organizations, but 20 concurrent jobs for repos under user accounts. This is a fairly significant blocker for migration to this organization.

Lokathor commented 4 years ago

Doesn't that just increase the time it takes by like an hour or whatever?

retep998 commented 4 years ago

@Lokathor A wincheck run with 20 concurrent jobs takes 2 hours 14 minutes. With only 5 concurrent jobs it would take roughly four times as long.

Lokathor commented 4 years ago

That's longish, but still within the "just do it overnight" range.