search

rust-x-bindings / rust-xcb

Rust bindings and wrapper for XCB.
MIT License
165 stars 64 forks source link

*Event fields having mask type in accessor function have generic type in new() argument #145

Closed xkr47 closed 2 years ago

xkr47 commented 2 years ago

(in v1.0-dev branch)

Examples:

  1. ConfigureRequestEvent: https://rust-x-bindings.github.io/rust-xcb/branches/v1.0-dev/xcb/x/struct.ConfigureRequestEvent.html
    • value_mask parameter is u16 in new() but ConfigWindowMask in value_mask()
  2. KeyPressEvent https://rust-x-bindings.github.io/rust-xcb/branches/v1.0-dev/xcb/x/struct.KeyPressEvent.html
    • state parameter is u16 in new() but KeyButMask in state()

Is this deliberatre or accidental?

rtbo commented 2 years ago

Hi, Thanks for reporting, no it is not deliberate

rtbo commented 2 years ago

Now fixed.