search

rust-x-bindings / rust-xcb

Rust bindings and wrapper for XCB.
MIT License
161 stars 63 forks source link

Fix special event API #261

Closed rtbo closed 4 months ago

rtbo commented 5 months ago

fixes #252 closes #253 closes #255 fixes #256

rtbo commented 5 months ago

Still thinking about how to fix #256

rtbo commented 4 months ago

@kvark do you think the stamp param is useful at all? In mesa, they increment the stamp each time they swap buffers, but the value is never read (AFAICT). In XCB, they increment the stamp each time a special event shows in the main loop, but the value is also never read...

If I have to support this parameter, I have to box it somehow in the SpecialEvent struct, which could then not be Send or Sync.

kvark commented 4 months ago

I don't think I can provide an informed opinion on this, sorry!