search

rust-x-bindings / xkbcommon-rs

bindings and safe wrappers for libxkbcommon
MIT License
20 stars 24 forks source link

Fix undefined behavior when creating Keymap #29

Closed StratusFearMe21 closed 2 years ago

StratusFearMe21 commented 2 years ago

I don't know what to tell you, all I know is that I was having problems before, and now I'm not. My reasoning is that I wanted to make sure that the lifetime of the String was at the top of the function instead of somewhere else

rtbo commented 2 years ago

I don't know for the lifetime, but your code looks better than mine! :smile: