search

rust3ds / ctru-rs

Rust wrapper for libctru
https://rust3ds.github.io/ctru-rs/
Other
117 stars 17 forks source link

Initial pass of `libctru` version checking in `ctru-sys` #101

Closed ian-h-chamberlain closed 1 year ago

ian-h-chamberlain commented 1 year ago

Partially addresses #100, but we'd probably want to do something as part of the CI release process as well.

This isn't set in stone, I'm just experimenting with some different things to see what makes sense. So far this seems to work pretty well, but I'm not sure if we want to encode the "duplicate" info with the + metadata on the build version as well as with the major/minor scheme mentioned in #100

Let me know what you think, I'll leave as a draft for now and we can discuss it.

Meziu commented 1 year ago

We should let people the have the choice to use an external libctru binary rather than requiring dkp-pacman. It would be helpful to ensure compatibility in the future.

ian-h-chamberlain commented 1 year ago

We should let people the have the choice to use an external libctru binary rather than requiring dkp-pacman. It would be helpful to ensure compatibility in the future.

That's a fair point. This change doesn't prevent anything like that, it would just display a warning that we couldn't determine the libctru version (and even then, that would only be displayed if using -vv or the compilation/linking failed). Hopefully that warning would give the user a clue that they might need to upgrade or use a supported version instead.