Clean up ctru-sys version checking

rust3ds / ctru-rs

Rust wrapper for libctru

https://rust3ds.github.io/ctru-rs/

Other

116 stars 17 forks source link

Clean up ctru-sys version checking #141

Closed ian-h-chamberlain closed 8 months ago

ian-h-chamberlain commented 9 months ago

Relates to #100 but maybe not totally resolved by this PR

Don't issue a warning for "mismatched version" since the new bindings make this irrelevant
Minor build script refactoring and code cleanup
Output a release version (-X) for libctru env vars
Revert version to 0.5.0, which is higher than we were using before the major 22.x version but should be ok since we never released to crates.io
Unconditionally link ctru (not ctrud) due to https://github.com/rust3ds/cargo-3ds/issues/14
- [x] don't love this, maybe there's a better option
[x] TODO I should update the README since it was documenting the version number convention but that also doesn't apply anymore

Meziu commented 9 months ago

Nice PR. As i said regarding the bindings PR, I am convinced that ctru-sys's version number should be separate from the libctru version that it links. I've also seen some changes regarding the general structure of tests and other things. I'll look around your changes once I manage to find some time :sweat_smile:.

ian-h-chamberlain commented 9 months ago

Nice PR. As i said regarding the bindings PR, I am convinced that ctru-sys's version number should be separate from the libctru version that it links. I've also seen some changes regarding the general structure of tests and other things. I'll look around your changes once I manage to find some time 😅.

No rush to review! With the way we're generating the bindings now I agreed in terms of version numbering, which is why I bumped it back down to 0.5.0. Most of the other stuff was just adding build script warnings and refactoring but feel free to review at your own pace 👍

ian-h-chamberlain commented 8 months ago

I was able to figure out something that I think works a little better for linking ctru, which in combination with https://github.com/rust3ds/cargo-3ds/pull/47 I think makes for a much better solution. Let me know what you think!