Closed ian-h-chamberlain closed 2 months ago
Great,
test-runner
is coming back home it seems π.Also, just noticed, but the changes made to
errorConf
(which rightfully set the final size to 3820) aren't being properly checked by the automatedbindgen
layout tests. Is there a way to override the expected result or avoid testing that type?
Actually, this is interesting βΒ yes, the bindgen
test seems to be incorrect (should be 3820), but our generated bindings also seem to be wrong! errorType
should have size 2 but it actually has size 4, from what I can tell. I'm not sure if there is a way to forcefully adjust the generated test or make sure it's the right size in practice, but I'll look into it.
My big fear is that this means some of our other binding tests are passing when really they should be failing π± so hopefully we can adjust something to make the tests more reliable
Great, all checks are passing now π
Let's just fix https://github.com/rust3ds/test-runner/pull/20 and we can merge this.
Related: #106, https://github.com/rust3ds/test-runner/issues/5
Simple drop-in from https://github.com/rust3ds/test-runner without any changes except for Cargo.toml
TODO: