nightly build Lan discovery brocken

[sanoj-m]

Bug Description

with the latest 1.1.9v the LAN discovery works very well. But I have tried to update it to Nightly build the latest version which broke the LAN discovery function.

I have self hosted the server in docker

How to Reproduce

update it to Nightly build the latest version

Expected Behavior

broke the LAN discovery function

Operating system(s) on local side and remote side

Windows 11

RustDesk Version(s) on local side and remote side

1.2.0

Screenshots

Additional Context

No response

[rustdesk]

@fufesou

[rustdesk]

make sure the other machines use nightly also.

[sanoj-m]

i have some nightly builds in my network.

another install below.

I have many 1.1.9 builds as well. as you can see below.

[fufesou]

@sanoj-m LAN discovery needs rustdesk installation. Do you install rustdesk on the other machines?

[sanoj-m]

yes all these devices has rustdesk installed in it

[fufesou]

Discovery will be triggered once when switching to the "Discovered" tab.

Did you make any switch?

Strangely, "Lan Discovery" works correctly on my computer.

[fufesou]

@sanoj-m Hi, please you check if this option is checked.

[sanoj-m]

as you can see, it's not disabled, I have switched back and forth multiple times.

Machine-1

Machine -2

[sanoj-m]

Machine-3

LAN Discovery

[rustdesk]

though we can not reproduce, but we do see a difference between 1.1.9 and nightly in code. We will make a quick enhancement, and let you test, please wait moment.

[sanoj-m]

It would be great.. Thanks

also, i would like to know about the PRO version timeline. I wish to have the pro features for my office administration functions like LDAP and sharing favorite's maybe?

[rustdesk]

Can you show us all your interfaces? Your local ip looks different.

https://github.com/rustdesk/rustdesk/blob/3c2fd6253c8569e94982dee7ff08090b439877ff/src/lan.rs#L170

Also show us log under something like %APPDATA%/rustdesk/logs/rustdesk_rCURRENT.log, if there is something like this.

https://github.com/rustdesk/rustdesk/blob/3c2fd6253c8569e94982dee7ff08090b439877ff/src/lan.rs#L183

[sanoj-m]

yes i could see an error in the logs

[2023-06-16 16:17:19.552437 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:20:59.016195 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:20:59.397549 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:21:00.566858 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:21:01.587907 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:21:02.367226 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:21:03.476452 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:21:04.641029 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:21:05.830436 +04:00] DEBUG [src\platform\windows.rs:1354] update portable executable name to rustdesk-1.2.0-x86_64 (4).exe [2023-06-16 16:21:07.009659 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:21:07.513490 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:21:07.885107 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:21:08.697136 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:24:53.402723 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:24:54.319772 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:25:25.505637 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:25:26.959063 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:25:27.452100 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:26:04.524929 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9 [2023-06-16 16:26:04.841501 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:26:06.408783 +04:00] DEBUG [libs\hbb_common\src\config.rs:479] Configuration path: C:\Users\Sanoj\AppData\Roaming\RustDesk\config\RustDesk_default.toml [2023-06-16 16:26:06.776251 +04:00] DEBUG [src\ui_interface.rs:562] Found no ipv4 addresses, librustdesk::ui_interface:src\ui_interface.rs:562:9

[rustdesk]

show us your interfaces please.

[sanoj-m]

[rustdesk]

Thanks, it is helpful, our guess is right.

[sanoj-m]

could you elaborate a bit, so i can try to fix it from bouncing to bail!("Found no ipv4 addresses"); ?

[rustdesk]

We will fix this, I think we should remove v4_addr.is_private().

[rustdesk]

We will try removing v4_addr.is_private() first. If it still does not work, we will swtich back to 1.1.9 solution, which send query with any address.

[sanoj-m]

Great to know.. Please update me once its ready, so i can check it out.

also, let me know if i can get the addressbook option?

[rustdesk]

https://github.com/rustdesk/rustdesk/actions/runs/5290250561, will be ready soon.

[rustdesk]

let me know if i can get the addressbook option?

Pro wil lbe ready soon, we are working hard on this. Maybe next monday. We will release pro and 1.2 together.

[rustdesk]

New build is ready. Can you test?

[sanoj-m]

Hello, i have tested the new build. its working fine.

i have another issue to mention. The user ID Change is not working

[rustdesk]

Pro