search

rusterlium / erlang_nif-sys

Low level bindings to Erlang NIF API for Rust
Apache License 2.0
90 stars 19 forks source link

Erlang 22 support #37

Open JJJollyjim opened 5 years ago

JJJollyjim commented 5 years ago

Erlang 22 is out (and in my case, my linux distro has updated), and with it comes NIF version 2.15. This means that NIFs won't build even with the latest erlang_nif-sys.

grahamhay commented 5 years ago

What needs to be done to implement Erlang 22 support?

goertzenator commented 5 years ago

Since I am not so involved in the project any more, I've sketched out the update process here.

OvermindDL1 commented 5 years ago

Any progress on this? A server went down when it received its automatic update as it wasn't able to rebuild the NIF's and so had to manually roll it back, which was not at all fun...

filmor commented 5 years ago

Support is on rustler master. erlang_nif_sys was vendored in there as erl_nif_sys, in which the changes have been made.

OvermindDL1 commented 5 years ago

@filmor Oh awesome, rustler is what I was needing, but any chance of PR'ing the changes back here for those that use this directly?

filmor commented 5 years ago

I don't think that would make much sense, seeing that further development will happen on the rustler repo. I'll have a look.

The PRs in question are https://github.com/rusterlium/rustler/pull/212 and https://github.com/rusterlium/rustler/pull/226.

filmor commented 5 years ago

See #39.