search

rusterlium / erlang_nif-sys

Low level bindings to Erlang NIF API for Rust
Apache License 2.0
90 stars 19 forks source link

WIP: Add support for Erlang 22 #38

Closed sultaniman closed 4 years ago

sultaniman commented 5 years ago

Hi,

In this PR tries to add missing definitions for Erlang 22 to resolve https://github.com/rusterlium/erlang_nif-sys/issues/37. At the moment I've been trying to figure out how to test since I'm quite new to Rust and Nifs as well. Any guidance and help will appreciated.

Thanks.

goertzenator commented 5 years ago

Thanks for taking this on. See slightly expanded test writing directions at https://github.com/rusterlium/erlang_nif-sys/wiki/Updating-this-package-for-new-OTP . Let me know if you need any more guidance.

sultaniman commented 5 years ago

Thanks for instructions, will now try to actually implement tests.

sultaniman commented 5 years ago

@goertzenator I added couple of test cases but not sure if they actually work as expected.

goertzenator commented 5 years ago

Travis CI is showing errors on your code. Are they helping you move forward?

sultaniman commented 5 years ago

@goertzenator I've been trying to fix them but at the moment unable to clearly understand what is needed. May be I need some help here.

lessless commented 5 years ago

Hi guys! Is there any progress on this?

sultaniman commented 5 years ago

@lessless @goertzenator sorry Im unable to dedicate time at least until september.