rustformers / llm

[Unmaintained, see README] An ecosystem of Rust libraries for working with large language models
https://docs.rs/llm/latest/llm/
Apache License 2.0
6.07k stars 355 forks source link

Rust 1.72 fixes #416

Closed philpax closed 1 year ago

philpax commented 1 year ago

Was trying to work on #412, but ended up side-tracked by this. The most problematic thing is the Arc non-Send/Sync lint; I went back and forth on this, but I was able to mostly convince myself that our current use is OK because we offer abstractions with different sync guarantees.

Still not 100% convinced though, I feel like our GGML bindings need a rethink to better fit Rust safety guarantees 😅