search

rustgd / cgmath

A linear algebra and mathematics library for computer graphics.
https://docs.rs/cgmath
Apache License 2.0
1.13k stars 155 forks source link

Add short constructors for points, to match the ones for vectors #476

Closed nstoddard closed 5 years ago

nstoddard commented 5 years ago

In my code I find that I need to create points almost as often as vectors, so having short constructors is helpful.

kvark commented 5 years ago

Looks good! I'd like an extra review on cgmath before we merge.

kvark commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build failed

kvark commented 5 years ago

Err, simd stuff. How does it compile for other PRs?.. bors retry

bors[bot] commented 5 years ago

Build failed

nstoddard commented 5 years ago

Can this be merged? I'm pretty sure the failed check isn't due to this PR.

kvark commented 5 years ago

bors retry

bors[bot] commented 5 years ago

Build failed

kvark commented 5 years ago

Trying to address the SIMD issue in #478

kvark commented 5 years ago

scheduling to land after #478 bors retry

bors[bot] commented 5 years ago

Build succeeded