search

rustgd / cgmath

A linear algebra and mathematics library for computer graphics.
https://docs.rs/cgmath
Apache License 2.0
1.12k stars 155 forks source link

Angle trait + Sized #510

Closed r4v3n6101 closed 4 years ago

r4v3n6101 commented 4 years ago

Angle is defined as unsized trait, but all of its implementors are sized (i.e. Rad and Deg). Maybe it should be defines as sized then? It helps define structs with Angle on stack instead of passing by &dyn Angle or generic like A: Angle<..> + Sized.

kvark commented 4 years ago

@r4v3n6101 sounds reasonable, let's do that!

r4v3n6101 commented 4 years ago

Closed as #511