search

rustic-games / jilu

Generate a change log based on the state of your Git repository.
104 stars 6 forks source link

Support both `vX.Y.Z` and `X.Y.Z` release tagging schemes #7

Closed JeanMertz closed 5 years ago

JeanMertz commented 5 years ago

Right now, tags require the format vX.Y.Z to be considered release tags (other formats don't produce any errors, but are ignored).

Jilu should also accept X.Y.Z, as those are the two most widely used formats to tag releases.

Basically, we should use semver::Version::parse on the tag, and the tag with the leading v stripped and accept the tag as a release tag if it passes the SemVer check.

cc: https://github.com/rustic-games/jilu/issues/5#issuecomment-520815076

JeanMertz commented 5 years ago

Resolved in 6b79f8725ed99db07c5199428d8b70cf35bc9eb2.