search

rusticata / asn1-rs

Parsers/Encoders for ASN.1 BER/DER data
Apache License 2.0
9 stars 14 forks source link

Missing license files in asn1-rs-impl-0.2.0.crate #37

Closed wojnilowicz closed 4 months ago

wojnilowicz commented 4 months ago

LICENSE-MIT and LICENSE-APACHE are missing in asn1-rs-impl-0.2.0.crate downloaded from https://crates.io/crates/asn1-rs-impl/0.2.0. Would you accept a PR similar to this one? I would like to package it as rpm for Fedora (which identifies missing license as a mistake and encourages upstream to include it) and it would make it easier. Thanks.

chifflier commented 4 months ago

Hi, Indeed, these files are missing, and that is unintentional. This also concerns asn1-rs-derive, by the way. These crates are helper crates not really meant to be used directly, but they should have a license file. Feel free to propose a PR if you want, or I can take care of it if you prefer. Thank you

wojnilowicz commented 4 months ago

Hi, in Fedora there is a tool called rust2rpm which downloads crates directly from crates.io and converts them to rpm packages. In that way they would be used directly but probably only as a dependency of asn1-rs.

I've posted a relevant PR. Thanks in advance for accepting it.