rusticata / asn1-rs

Parsers/Encoders for ASN.1 BER/DER data
Apache License 2.0
9 stars 14 forks source link

Update cargo-check-external-types rustc version #41

Closed cpu closed 3 months ago

cpu commented 3 months ago

:wave: As promised, when cargo-check-external-types makes an update I'm opening PRs to fix the builds :-)

Note: there seems to be another unrelated breakage with nightly clippy, a finding from unexpected-cfgs. I'm not sure what the right fix is in this case: it seems like "exact_size_is_empty" is being used as a feature gate for the unstable nightly feature (https://github.com/rust-lang/rust/issues/35428) and I'm not sure how to square that requirement with the new lint. Suggestions welcome!

chifflier commented 3 months ago

Hi, I checked but it seems that there is no easy way for us to check for the nightly feature. Anyway, the function was mostly provided as a helper, we do not use it. Removed in 382dacf

chifflier commented 3 months ago

Applied, thanks!