search

rusticata / kerberos-parser

Kerberos parser written in rust with nom
Apache License 2.0
14 stars 4 forks source link

Parse_kdc_rep in krb5_parser.rs seems don't work properly. #9

Closed hchsoon closed 2 years ago

hchsoon commented 2 years ago

Hey there, it occurred to me that some fields would not be properly extracted when padata, the optional field, is absent. From my perspective, it could be caused by the unwrap_or_default function. If no padata found there , i, the remaining data here, would be empty as the default return value. Consequently, the following fields would never be parsed.

chifflier commented 2 years ago

Good catch, thanks! I will check that there are no similar errors in the code, and push a commit to fix this.

chifflier commented 2 years ago

fix published in release 0.7.1