rusticata / x509-parser

X.509 parser written in pure Rust. Fast, zero-copy, safe.
Other
206 stars 67 forks source link

Update time dependency to 0.3.9. #123

Closed jasonish closed 1 year ago

jasonish commented 2 years ago

This is to address the cargo audit issues around time and the RustSec advisory https://rustsec.org/advisories/RUSTSEC-2020-0071.html.

Migrate from time 0.1 to time 0.3. Due to issues parsing YYMM formatted years with time 3, provide a crude date parser.

This is for use in the Suricata 6.0.x branch which currently uses x509-parser 0.6.5.

victorjulien commented 2 years ago

Will this bump the MSRV? In suri 6 we use 1.41.1 currently.

jasonish commented 2 years ago

It does. I was working yesterday on the assumption it built on 1.32 or something. I was looking at the wrong page, and obviously didn't test.

chifflier commented 1 year ago

Applied, thanks! It is a breaking change (some fields are public), however the situation with the time crate have been ongoing for too long and justifies a forced update.