search

rusticata / x509-parser

X.509 parser written in pure Rust. Fast, zero-copy, safe.
Other
206 stars 67 forks source link

Fix receiver lifetimes in `AttributeTypeAndValue`. #141

Closed SergioBenitez closed 1 year ago

SergioBenitez commented 1 year ago

This builds off https://github.com/rusticata/asn1-rs/pull/22.

SergioBenitez commented 1 year ago

Note that this PR depends on https://github.com/rusticata/asn1-rs/pull/22, so we expect tests to fail until that PR is merged and dependencies are updated as needed.

SergioBenitez commented 1 year ago

Checking on this. Can we get this merged? We still need a release of asn1 for this PR to work.

SergioBenitez commented 1 year ago

Checking in again.

chifflier commented 1 year ago

Manually merged in 109e0aa031caeab78b44a71befea7be89452ebd5 and 853d7ee1de14bd57c65e6b6493e9a4655740e490 Thanks!

SergioBenitez commented 10 months ago

Please revert https://github.com/rusticata/x509-parser/commit/853d7ee1de14bd57c65e6b6493e9a4655740e490 and any other such changes and publish a new breaking release.