search

rusticata / x509-parser

X.509 parser written in pure Rust. Fast, zero-copy, safe.
Other
206 stars 67 forks source link

extensions: parse CRL issuing distribution point. #146

Closed cpu closed 6 months ago

cpu commented 1 year ago

Prior to this branch the x509-parser extension parsing code recognized the certificate CRL distribution points extension (RFC 5280 Section 4.2.1.13), but not the corresponding CRL issuing distribution point extension (RFC 5280 Section 5.2.5).

This commit adds the missing support, leveraging the existing code for parsing distribution point name fields and revocation reason fields.

cpu commented 1 year ago

Continuous integration / Clippy (pull_request) Failing after 41s

These findings affect master and are not specific to this branch. I've put up a fix in a separate PR: https://github.com/rusticata/x509-parser/pull/147

cpu commented 7 months ago

Thanks for the review :-) Your feedback seems reasonable. I can integrate it over the next day or so.

cpu commented 7 months ago

@chifflier I've addressed your feedback and I think this is ready for another review when you have a chance. Thanks.

chifflier commented 6 months ago

Merged, thanks!