project CI refresh - Githubissues

rusticata / x509-parser

X.509 parser written in pure Rust. Fast, zero-copy, safe.

Other

215 stars 68 forks source link

project CI refresh #158

Closed cpu closed 6 months ago

cpu commented 6 months ago

Continuing the CI standardization and refresh started in https://github.com/rusticata/rusticata-macros/pull/8

Note: I've left out the cargo check-external-types CI addition I've been adding in other refresh PRs. Something about this repo is giving the tool some trouble (it seems to stall in CI after "Examining all public types..."). I'd like to revisit this when I have more time to debug so for now I've left it out.

chifflier commented 6 months ago

Merged, thanks

I do not have ideas yet for the problem with cargo check-external-types, but I suspect this is caused by some complexity in using types from multiple crates that end up being the same, but reexported (for ex asn1-rs::IResult is the same as der-parser::IResult and also as nom::IResult). As explained earlier, they need to be the same to be able to easily combine them. However, reexporting may not be the best solution, but I have not investigated other solutions.