search

rustls / rcgen

Generate X.509 certificates, CSRs
Other
346 stars 108 forks source link

Pass extended key usage parameters when importing CertificateSigningRequestParams #264

Closed uglyoldbob closed 6 months ago

uglyoldbob commented 7 months ago

This pull requests adds parsing of most of the extended key usage parameters, except for Other.

est31 commented 7 months ago

Also, please squash after the fixes. I see a merge commit in the PR :).

cpu commented 7 months ago

Would you be able to add some test coverage to this branch?

uglyoldbob commented 7 months ago

Looks like making a second version of the test_certificate_from_csr test or modifying that test to include the extended key usage would work. Any preference as to which one?

cpu commented 7 months ago

modifying that test to include the extended key usage would work. Any preference as to which one?

That sounds reasonable to me :+1:

uglyoldbob commented 7 months ago

Support for the extended key usage probably needs to be added to CertificateParams::serialize_request.

djc commented 7 months ago

@uglyoldbob thanks, this is looking good!

@cpu, want to have a look before merging this? Already has @est31 approval.

(Let's bypass the merge queue to squash?)

cpu commented 7 months ago

@cpu, want to have a look before merging this?

:+1: I will take a look today