search

rustls / rcgen

Generate X.509 certificates, CSRs
Other
346 stars 108 forks source link

error: feature-gate ExternalError #271

Closed cpu closed 6 months ago

cpu commented 6 months ago

This trait is only used when the crypto or pem features are enabled, producing a warning with Rust 1.80 clippy (as seen in CI failures) when building with --no-default-features. This commit config-gates its definition to avoid that warning.

cpu commented 6 months ago

~Since this is a small non-functional change I'm going to merge with one review to fix CI.~ Edit: ended up needing another commit.

cpu commented 6 months ago

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

Nightly updated and there's some new findings of the form "error: unexpected cfg condition name: crypto". I'll push a fix commit into this branch.

cpu commented 6 months ago

I'll push a fix commit into this branch.

Done. The reported errors from nightly helped uncovered we had some inert unit tests that also needed fixing. Nice :+1:

cpu commented 6 months ago

This still feels non-functional/small enough to merge without blocking for another review. Happy to re-calibrate for next time if I'm jumping the gun.