search

rustls / rustls-ffi

Use Rustls from any language
Other
125 stars 30 forks source link

Build fails due to updated indexmap dev-dependency #268

Closed jsha closed 2 years ago

jsha commented 2 years ago

We build with Rust 1.52.1 in CI because that's our MSRV. As of today we're getting:

  Downloaded hashbrown v0.12.1
error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.12.1/Cargo.toml`
Caused by:
Makefile:30: recipe for target 'test-rust' failed
  feature `edition2021` is required

hashbrown is a transitive dev-dependency: cbindgen -> indexmap -> hashbrown. As of last night, hashbrown released a new version that says This version of indexmap requires Rust 1.56.1 or later.

Since this is only a dev dependency, and src/rustls.h is no longer automatically generated on each Make invocation, I think we should change CI so most platforms don't try to run cbindgen. Effectively this will mean 1.52.1 can build rustls-ffi, but 1.56.1 or later is required to developer rustls-ffi.