I think it makes sense to duplicate this change in the rustls-ffi API, changing rustls_server_connection_get_sni_hostname to be rustls_server_connection_get_server_name. I think its clearer to match upstream and it would also be consistent with existing fns like rustls_accepted_server_name.
cpu
commented
1 year ago
The upstream Rustls project changed the
ServerConnection'ssni_hostnamefunction to be namedserver_name. See https://github.com/rustls/rustls/commit/9b8fa40.I think it makes sense to duplicate this change in the rustls-ffi API, changing
rustls_server_connection_get_sni_hostnameto berustls_server_connection_get_server_name. I think its clearer to match upstream and it would also be consistent with existing fns likerustls_accepted_server_name.Something like this: https://github.com/cpu/rustls-ffi/commit/c68e826fe1404914f9c9ff0572658edda585e18f