rustls / rustls-ffi

Use Rustls from any language
Other
124 stars 31 forks source link

client auth type constructor changes #296

Closed cpu closed 1 year ago

cpu commented 1 year ago

The upstream Rustls project changed the NoClientAuth, AllowAnyAuthenticatedClient, and AllowAnyAnonymousOrAuthenticatedClient constructors in https://github.com/rustls/rustls/commit/cd4f5c9, harmonizing the interfaces but breaking the existing rustls-ffi usage.

The upstream constructor for NoClientAuth was renamed from new to boxed. A small change is required to accommodate this rustls-ffi: https://github.com/cpu/rustls-ffi/commit/94ba1d2fedce85fa826bc3564e5bc5804eafc1ce

Similarly, both AllowAnyAuthenticatedClient and AllowAnyAnonymousOrAuthenticatedClient had their new constructors changed from returning an Arc to returning Self and offering a separate boxed fn for wrapping in an Arc. This can be accomated in rustls-ffi with a change like: https://github.com/cpu/rustls-ffi/commit/e68b382c6ac70e37a7cc24f59eb2e2de51af505f

cpu commented 1 year ago

Resolved in the rustls-0.21.0 branch.