search

rustls / rustls-ffi

Use Rustls from any language
Other
124 stars 31 forks source link

server: adjust sni_hostname() -> server_name(). #298

Closed cpu closed 1 year ago

cpu commented 1 year ago

This follows the upstream change in Rustls to prefer server_name over sni_hostname. See rustls/rustls@9b8fa40.

Resolves https://github.com/rustls/rustls-ffi/issues/295

jsha commented 1 year ago

Thanks!

jsha commented 1 year ago

As a note: I edited the commit message to omit See https://github.com/rustls/rustls/commit/9b8fa40. With GitHub's way of pinging issues and PRs, I generally avoid such pings in commits, since it means forks, other branches, etc. can wind up pinging accidentally.

Of course, having done so I realize that linking to commits has no such pinging problem. Sorry about that!

cpu commented 1 year ago

Of course, having done so I realize that linking to commits has no such pinging problem. Sorry about that!

No worries :+1: Now that you've mentioned it I do recall reading in the upstream rustls CONTRIBUTING.md to avoid linking GitHub issues or PRs: https://github.com/rustls/rustls/blob/main/CONTRIBUTING.md#code-changes It doesn't explicitly mention commits but it seems in keeping with the spirit of the doc to avoid those too. I'll adjust for future contributions.