search

rustls / rustls-ffi

Use Rustls from any language
Other
124 stars 31 forks source link

Remove and ignore Cargo.lock #312

Closed jsha closed 1 year ago

jsha commented 1 year ago

We temporarily committed this file while working on the 0.21 branch, so we could lock a specific commit of the upstream rustls. Now we go back to our default stance as a library, which is to not lock our dependencies.

Also, update verify-static-libraries.py.

jsha commented 1 year ago

The build failure is:

Got unexpected list of native static libraries, fix or update README. Got:
 advapi32.lib credui.lib kernel32.lib secur32.lib legacy_stdio_definitions.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib msvcrt.lib legacy_stdio_definitions.lib
Instead of:
 advapi32.lib credui.lib kernel32.lib secur32.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib msvcrt.lib legacy_stdio_definitions.lib
Error: Process completed with exit code 1.

(on Windows)

This list often changes between Rust releases, and there was a Rust release on 2023-03-28. So I suspect it's that.

I'll incorporate an update to this list, and file an issue to rethink how we manage it.

cpu commented 1 year ago

@jsha Weird! That difference in the list of expected vs actual looks like the undoing of the adjustment we made in the prep branch: https://github.com/rustls/rustls-ffi/commit/0d5ac8bec1121eb4c78124216ee9d3039b4dff6c I wonder why its flip-flopping the inclusion of that duplicate legacy_stdio_definitions.lib entry