search

rustls / rustls-ffi

Use Rustls from any language
Other
124 stars 31 forks source link

checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED no" apache #314

Open davideperson opened 1 year ago

davideperson commented 1 year ago

hi i'm having problem make a pre-check of source code of latest version of httpd available httpd 2.4.57

any idea how to fix it ?

cpu commented 1 year ago

Hi there,

Are you trying to build Apache with mod_tls using the rustls-ffi backend?

The rustls crate doesn't use pkg-config to my knowledge so I suspect you might have to open your issue with the Apache project to start out. I'd recommend including the commands your're running, the version of your operating system and build tooling, and the output log if possible.

davideperson commented 1 year ago

Hi there,

Are you trying to build Apache with mod_tls using the rustls-ffi backend?

The rustls crate doesn't use pkg-config to my knowledge so I suspect you might have to open your issue with the Apache project to start out. I'd recommend including the commands your're running, the version of your operating system and build tooling, and the output log if possible.

i've used this command to build apache ./configure --enable-ssl --enable-so --with-mpm=event --with-included-apr --prefix=/etc/httpd

cpu commented 1 year ago

@davideperson Issues with the Apache HTTPD build process will need to be discussed with the Apache HTTPD maintainers. I recommend you open an issue with that project instead of Rustls.

djc commented 1 year ago

This might be more usefully reported against https://github.com/rustls/rustls-ffi (given that this is looking for pkg-config info for rustls-ffi) or against https://bz.apache.org/bugzilla/enter_bug.cgi?product=Apache%20httpd-2&component=mod_tls (the mod_tls module in the Apache httpd bug tracker).

cc @jsha @icing

icing commented 1 year ago

The checks in Apache for mod_tls have not changes since it was first released. Has something changed on the rustls-ffi side?

davideperson commented 1 year ago

any idea how to fix it?

icing commented 1 year ago

What exactly is the configure command line and what is the error you are seeing?

rustls-ffi had its last release on Nov 14, 2021, and with that we are building. Are you using something else?

davideperson commented 1 year ago

What exactly is the configure command line and what is the error you are seeing?

rustls-ffi had its last release on Nov 14, 2021, and with that we are building. Are you using something else?

This is the procedure i did from centos 8 linux system

wget https://dlcdn.apache.org/httpd/httpd-2.4.57.tar.gz wget https://dlcdn.apache.org//apr/apr-util-1.6.3.tar.gz wget https://dlcdn.apache.org/apr/apr-1.7.4.tar.gz

untar all archives

tar -xvzf httpd-2.4.57.tar.gz tar -xvzf apr-util-1.6.3.tar.gz tar -xvzf apr-1.7.4.tar.gz

mv apr-util-1.6.3 folder to httpd-2.4.57/srclib/apr-util mv apr-1.7.4 folder to httpd-2.4.57/srclib/apr

cd httpd-2.4.57

./configure --enable-ssl --enable-so --with-mpm=event --with-included-apr --prefix=/etc/httpd

output -- > apache.txt

if you find the word FAILED you will find this string

checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED

i've tried everything but i'm not able to install rustls for Apache HTTP Server 2.4.57

jsha commented 1 year ago

I've moved this issue to the rustls-ffi repository.

Here's the snippet from the linked apache.txt:

checking whether to enable mod_tls... checking dependencies
checking for rustls... checking for user-provided rustls base directory... none
checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED
no
checking whether to enable mod_tls... no (disabled)

@davideperson in your setup details, I don't see any step where you built and installed rustls-ffi. Have you done that?

@icing actually there's an 0.10.0 release tagged as of March 29: https://github.com/rustls/rustls-ffi/releases/tag/v0.10.0. But that's via the tag mechanism; I did not create a GitHub Release for it. I'll do that now.

icing commented 1 year ago

Ah, thanks for making the release visible. I‘ll take that out for a spin next week. Am 29.04.2023 um 00:09 schrieb Jacob Hoffman-Andrews @.***>: I've moved this issue to the rustls-ffi repository. Here's the snippet from the linked apache.txt: checking whether to enable mod_tls... checking dependencies checking for rustls... checking for user-provided rustls base directory... none checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED no checking whether to enable mod_tls... no (disabled)

@davideperson in your setup details, I don't see any step where you built and installed rustls-ffi. Have you done that? @icing actually there's an 0.10.0 release tagged as of March 29: https://github.com/rustls/rustls-ffi/releases/tag/v0.10.0. But that's via the tag mechanism; I did not create a GitHub Release for it. I'll do that now.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

davideperson commented 1 year ago

I've moved this issue to the rustls-ffi repository.

Here's the snippet from the linked apache.txt:

checking whether to enable mod_tls... checking dependencies
checking for rustls... checking for user-provided rustls base directory... none
checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED
no
checking whether to enable mod_tls... no (disabled)

@davideperson in your setup details, I don't see any step where you built and installed rustls-ffi. Have you done that?

@icing actually there's an 0.10.0 release tagged as of March 29: https://github.com/rustls/rustls-ffi/releases/tag/v0.10.0. But that's via the tag mechanism; I did not create a GitHub Release for it. I'll do that now.

thanks all for the help , i've tried to install rustls using command cargo install rustls on linux, but downloading source code from https://github.com/rustls/rustls-ffi and build it up helped me fix the error on previous log of apache.txt i've posted checking for pkg-config along ... checking for rustls version >= 0.8.2... FAILED

now i received

checking for rustls... checking for user-provided rustls base directory... none checking for pkg-config along ... checking for rustls version >= 0.8.2... OK yes

davideperson commented 1 year ago

after i've run this command on httpd source code without having error anymore

./configure --enable-ssl --enable-so --with-mpm=event --with-included-apr --prefix=/etc/httpd

i've tried to build up latest apache version with command make && make install

now i have this is error:

tls_core.c: In function 'extract_client_hello_values':
tls_core.c:510:16: error: 'rustls_client_hello' {aka 'const struct rustls_client_hello'} has no member named 'sni_name'; did you mean 'server_name'?
     if (hello->sni_name.len > 0) {
                ^~~~~~~~
                server_name
tls_core.c:511:57: error: 'rustls_client_hello' {aka 'const struct rustls_client_hello'} has no member named 'sni_name'; did you mean 'server_name'?
         cc->sni_hostname = apr_pstrndup(c->pool, hello->sni_name.data, hello->sni_name.len);
                                                         ^~~~~~~~
                                                         server_name
tls_core.c:511:79: error: 'rustls_client_hello' {aka 'const struct rustls_client_hello'} has no member named 'sni_name'; did you mean 'server_name'?
         cc->sni_hostname = apr_pstrndup(c->pool, hello->sni_name.data, hello->sni_name.len);
                                                                               ^~~~~~~~
                                                                               server_name
make[4]: *** [/home/httpd/httpd-2.4.57/build/rules.mk:212: tls_core.slo] Error 1
make[4]: Leaving directory '/home/httpd/httpd-2.4.57/modules/tls'
make[3]: *** [/home/httpd/httpd-2.4.57/build/rules.mk:117: shared-build-recursive] Error 1
make[3]: Leaving directory '/home/httpd/httpd-2.4.57/modules/tls'
make[2]: *** [/home/httpd/httpd-2.4.57/build/rules.mk:117: shared-build-recursive] Error 1
make[2]: Leaving directory '/home/httpd/httpd-2.4.57/modules'
make[1]: *** [/home/httpd/httpd-2.4.57/build/rules.mk:117: shared-build-recursive] Error 1
make[1]: Leaving directory '/home/httpd/httpd-2.4.57'
make: *** [/home/httpd/httpd-2.4.57/build/rules.mk:75: all-recursive] Error 1

this is the output of make && make install command make&&make install_log.txt

icing commented 1 year ago

I made the necessary changes in apache's trunk and 2.4.x branches and configure also checks for a more recent rustls-ffi version.