Another instance of a f-string gone awry. It might be nice to RIIR this integration test driver, or invest in more Python CI capabilities (like running flake8) to catch this class of bug sooner.
tests: print headers for client/server test types
I was finding it challenging to quickly scan the client/server integration test output to identify which scenario was failing. This commit adds some headers to make that easier.
tests: check add pem result in server.c
Previously the result from adding a PEM input file to a root cert store wasn't being checked. This was an omission from https://github.com/rustls/rustls-ffi/pull/321 Unfortunately it seems clang-tidy doesn't catch this :cry: My kingdom for #[must_use] return type annotations.
lib: note BoxCastPtr/ArcCastPtr are mutually exclusive
As discussed in #341, only one of BoxCastPtr or ArcCastPtr should be implemented for a type
Pulling out a handful of small changes from https://github.com/rustls/rustls-ffi/pull/341 that can be landed immediately without blocking on a finalized Rustls release.
tests: fix f-string in client-server.py
Another instance of a f-string gone awry. It might be nice to RIIR this integration test driver, or invest in more Python CI capabilities (like running
flake8
) to catch this class of bug sooner.tests: print headers for client/server test types
I was finding it challenging to quickly scan the client/server integration test output to identify which scenario was failing. This commit adds some headers to make that easier.
tests: check add pem result in server.c
Previously the result from adding a PEM input file to a root cert store wasn't being checked. This was an omission from https://github.com/rustls/rustls-ffi/pull/321 Unfortunately it seems
clang-tidy
doesn't catch this :cry: My kingdom for#[must_use]
return type annotations.lib: note BoxCastPtr/ArcCastPtr are mutually exclusive
As discussed in #341, only one of
BoxCastPtr
orArcCastPtr
should be implemented for a type