Fix valgrind job - Githubissues

rustls / rustls-ffi

Use Rustls from any language

Other

127 stars 30 forks source link

Closed ctz closed 6 months ago

ctz commented 6 months ago

export VALGRIND="valgrind -q" doesn't work as intended:

in GH actions, environment alterations don't affect subsequent run steps
in tests/client_server.rs, we require VALGRIND to be a single command to execute: no shell expansion takes place so no arguments are allowed

cpu commented 6 months ago

Since this is a simple fix and doesn't involve any non-CI updates I think it's fair to merge without blocking on additional reviews.