Closed rami3l closed 4 weeks ago
I guess this should be equivalent to the cfg expression that adds the dependency on rustls-native-certs
in the first place.
We should probably remove this once rustls/rustls-native-certs#28 is addressed, and also alter our freebsd CI job so it doesn't accidentally work around that bug by installing curl.
I guess this should be equivalent to the cfg expression that adds the dependency on rustls-native-certs in the first place.
@ctz Thanks! I've started an experiment in https://github.com/rust-lang/rustup/pull/3912 to see whether your proposed changes do the job.
Update: It works! I've made #105.
Hello there! After the Rustup team's recent attempt to migrate to
rustls-platform-verifier
(https://github.com/rust-lang/rustup/pull/3903) we have noticed a CI regression as follows:Interestingly enough, before the migration we have used
reqwest
's integration ofrustls-native-certs v0.7.0
and it didn't fail:Comparing the usage of
rustls_native_certs::load_native_certs
inreqwest
andrustls-platform-verifier
, I have noticed that here this function is under a guard that is disabled on FreeBSD (https://github.com/rust-lang/rustup/issues/3908#issuecomment-2191368278):https://github.com/rustls/rustls-platform-verifier/blob/2b3bfbe9789b15748364e5b8c1b7f93848dea26e/rustls-platform-verifier/src/verification/others.rs#L118-L119
Could this be a mistake of some sort? Does it have something to do with the snippet below?
https://github.com/rustls/rustls-platform-verifier/blob/2b3bfbe9789b15748364e5b8c1b7f93848dea26e/rustls-platform-verifier/Cargo.toml#L51-L53
Many thanks in advance!