search

rustls / rustls-platform-verifier

A certificate verification library for rustls that uses the operating system's verifier
Apache License 2.0
66 stars 20 forks source link

FreeBSD support #53

Closed Ralith closed 9 months ago

Ralith commented 9 months ago

This is blocking Quinn from shipping rustls-platform-verifier helpers out of the box (https://github.com/quinn-rs/quinn/pull/1734). May be as simple as replacing cfg(target_os = "linux") with cfg(all(unix, not(target_os = "macos"), not(target_os = "ios"))).

cpu commented 9 months ago

That seems reasonable. I think the more interesting aspect will be CI coverage. It looks like Quinn is using vmactions/freebsd-vm@v1 for that. I suppose we should follow suit?

complexspaces commented 9 months ago

I agree this is just an oversight and FreeBSD support should be expected. vmactions/freebsd-vm@v1 seems like it's pretty widely used on GitHub.

As for the proper gate, I think we want this for the other.rs module. Android has its own implementation, not just Apple's platforms:

cfg(all(unix, not(target_os = "android") not(target_os = "macos"), not(target_os = "ios")))
cpu commented 9 months ago

https://github.com/rustls/rustls-platform-verifier/pull/55