search

rustls / rustls-platform-verifier

A certificate verification library for rustls that uses the operating system's verifier
Apache License 2.0
57 stars 18 forks source link

Fix clippy tvOS build, resolve cargo audit finding, fix expired cert #91

Closed cpu closed 2 months ago

cpu commented 2 months ago

ci: use aarch64 toolchain on macos-latest

The runner image was upgraded and is no longer x86-64, but aarch64. This change broke the Clippy tvOS build task ~4 days ago when the change was rolled out. See this GitHub changelog post for more information.

Cargo: update rustls 0.23.1 -> 0.23.5

Notably this resolves a cargo deny finding in rustls (https://github.com/rustls/rustls/security/advisories/GHSA-6g7w-8wpp-frhj) that, while not at all applicable to this crate, was failing the audit check in CI (example).

tests: update letsencrypt_org_valid_1.crt

The existing copy expired yesterday and is breaking the Android CI job:

04-27 18:24:33.974  3186  3202 I rustls_platform_verif..: -----------------------------------------------------------------------------
04-27 18:24:33.975  3186  3229 I rustls_platform_verif..: verifying ref ID "letsencrypt.org" expected Ok(())
04-27 18:24:33.986  3186  3229 E rustls_platform_verif..: failed to verify TLS certificate: invalid peer certificate: Expired
04-27 18:24:33.986  3186  3229 E rustls_platform_verif..: test panic: assertion `left == right` failed
04-27 18:24:33.986  3186  3229 E rustls_platform_verif..:   left: Err(InvalidCertificate(Expired))
04-27 18:24:33.986  3186  3229 E rustls_platform_verif..:  right: Ok(())
04-27 18:24:33.987  3186  3202 E rustls_platform_verif..: real world: test failed
04-27 18:24:33.988  3186  3202 I rustls_platform_verif..: -----------------------------------------------------------------------------