search

rustls / tokio-rustls

Async TLS for the Tokio runtime
Apache License 2.0
125 stars 70 forks source link

Test failure in common::test_stream::stream_handshake_regression_issues_77 #67

Closed djc closed 7 months ago

djc commented 7 months ago

First seen in a scheduled CI run:

https://github.com/rustls/tokio-rustls/actions/runs/8843164500

I was able to reproduce it locally -- the test passed at first, but failed after cargo update:

djc-2021 main tokio-rustls $ cargo update
    Updating crates.io index
    Updating aho-corasick v1.1.2 -> v1.1.3
    Updating autocfg v1.1.0 -> v1.2.0
    Updating aws-lc-fips-sys v0.12.5 -> v0.12.7
    Updating aws-lc-rs v1.6.2 -> v1.7.0
    Updating aws-lc-sys v0.13.2 -> v0.15.0
    Updating backtrace v0.3.69 -> v0.3.71
    Updating base64 v0.21.5 -> v0.22.0
    Removing bitflags v1.3.2
    Removing bitflags v2.4.2
      Adding bitflags v2.5.0
    Updating bytes v1.5.0 -> v1.6.0
    Updating cc v1.0.83 -> v1.0.95
    Updating either v1.10.0 -> v1.11.0
    Updating futures-core v0.3.29 -> v0.3.30
    Updating futures-macro v0.3.29 -> v0.3.30
    Updating futures-task v0.3.29 -> v0.3.30
    Updating futures-util v0.3.29 -> v0.3.30
    Updating getrandom v0.2.11 -> v0.2.14
    Updating gimli v0.28.0 -> v0.28.1
    Updating hermit-abi v0.3.3 -> v0.3.9
      Adding jobserver v0.1.31
    Updating libc v0.2.150 -> v0.2.153
    Updating libloading v0.8.1 -> v0.8.3
    Updating lock_api v0.4.11 -> v0.4.12
    Updating log v0.4.20 -> v0.4.21
    Updating memchr v2.6.4 -> v2.7.2
    Updating miniz_oxide v0.7.1 -> v0.7.2
    Updating mio v0.8.9 -> v0.8.11
    Updating object v0.32.1 -> v0.32.2
    Updating parking_lot v0.12.1 -> v0.12.2
    Updating parking_lot_core v0.9.9 -> v0.9.10
    Updating pin-project-lite v0.2.13 -> v0.2.14
    Updating prettyplease v0.2.16 -> v0.2.19
    Updating proc-macro2 v1.0.78 -> v1.0.81
    Updating quote v1.0.35 -> v1.0.36
    Updating redox_syscall v0.4.1 -> v0.5.1
    Updating regex v1.10.3 -> v1.10.4
    Updating regex-automata v0.4.5 -> v0.4.6
    Updating regex-syntax v0.8.2 -> v0.8.3
    Updating ring v0.17.5 -> v0.17.8
    Updating rustix v0.38.28 -> v0.38.34
    Updating rustls v0.23.1 -> v0.23.5
    Updating rustls-pemfile v2.0.0 -> v2.1.2
    Updating rustls-pki-types v1.3.1 -> v1.5.0
    Updating rustls-webpki v0.102.2 -> v0.102.3
    Updating serde v1.0.193 -> v1.0.198
    Updating serde_derive v1.0.193 -> v1.0.198
    Updating signal-hook-registry v1.4.1 -> v1.4.2
    Updating smallvec v1.11.2 -> v1.13.2
    Updating socket2 v0.5.5 -> v0.5.6
    Updating syn v2.0.52 -> v2.0.60
    Updating tokio v1.34.0 -> v1.37.0
    Updating webpki-roots v0.26.0 -> v0.26.1
    Updating windows-targets v0.52.4 -> v0.52.5
    Updating windows_aarch64_gnullvm v0.52.4 -> v0.52.5
    Updating windows_aarch64_msvc v0.52.4 -> v0.52.5
    Updating windows_i686_gnu v0.52.4 -> v0.52.5
      Adding windows_i686_gnullvm v0.52.5
    Updating windows_i686_msvc v0.52.4 -> v0.52.5
    Updating windows_x86_64_gnu v0.52.4 -> v0.52.5
    Updating windows_x86_64_gnullvm v0.52.4 -> v0.52.5
    Updating windows_x86_64_msvc v0.52.4 -> v0.52.5
djc commented 7 months ago

This is a change from rustls 0.23.4 -> 0.23.5, so probably due to https://github.com/rustls/rustls/pull/1905.

djc commented 7 months ago

Original issue: https://github.com/tokio-rs/tls/issues/77 and fix in https://github.com/tokio-rs/tls/pull/78.