search

rustls / webpki-roots

CA certificates for use with webpki
Apache License 2.0
89 stars 47 forks source link

v0.25.3 release preparation #53

Closed cpu closed 11 months ago

cpu commented 11 months ago

Description

This branch targets the rel-0.25 branch, which was branched from 22702f5e206604890349983f9c334dbc244d6f18, the last commit on main that's semver compatible with the 0.25.2 release cut from 4730449082b71d0a4f704b9180711e4d03995fc2. It backports the CCADB trust root updates from https://github.com/rustls/webpki-roots/pull/52 to prepare v0.25.3

Proposed Release Notes

New trust anchors:

Removed trust anchors:

cpu commented 11 months ago

Why not branch from https://github.com/rustls/webpki-roots/commit/22702f5e206604890349983f9c334dbc244d6f18? Seems a bit more clear in terms of the commit history.

As in start the rel-0.25 branch from 22702f5e206604890349983f9c334dbc244d6f18? In the past when I've made the rel-xxx branches I've always branched from whatever commit was used for the most recent release in that stream, usually the one bumping the Cargo.toml version. It felt like the point releases should always pick up from where the last release left off :thinking:

djc commented 11 months ago

As in start the rel-0.25 branch from 22702f5? In the past when I've made the rel-xxx branches I've always branched from whatever commit was used for the most recent release in that stream, usually the one bumping the Cargo.toml version. It felt like the point releases should always pick up from where the last release left off 🤔

It seems fair game to me to pick a later commit from the main branch that is still compatible with the 0.25.x range. If we make this clear in the PR description (maybe including mentioning the first PR that introduced incompatible changes), I think that would be a cleaner way of maintaining the commit history.

cpu commented 11 months ago

I think that's reasonable for this repo where it's very clear what commit is the delineating point between compatible/incompatible. I will adjust :+1:

cpu commented 11 months ago
cpu commented 11 months ago

I also noticed we were missing tags for 0.25.2, 0.25.1, and 0.25.0. I retroactively pushed all of those tags to GitHub (but haven't created GitHub releases for all of the historic tagged Cargo releases)