search

rustne-kretser / noline

IO-agnostic line editor for embedded systems
Mozilla Public License 2.0
96 stars 9 forks source link

Add LF as a valid line terminator #19

Closed m5p3nc3r closed 8 months ago

m5p3nc3r commented 1 year ago

Useful for when piping from unix which generates LF, not CRLF

For example:

> echo "Hello world" | base64 -b 8 -i - | cat -e 
SGVsbG8g$
d29ybGQK$
$
$

The $ indicates a LF. If it was to have CRLF, it would show ast ^M$

m5p3nc3r commented 1 year ago

I can see a few failures on the CI. The first I understand, and will add a line to the changelog. The second 'cargo outdated', do you really want me to update the packages as a part of this PR? Happy to do so if needed.

m5p3nc3r commented 1 year ago

One last question before what will hopefully be my last commit. I am using prettier to auto-format the code, which is adding whitespace changes to some of the configuration files. Are you happy to accept these changes, or should I turn off prettier whilst working on your repo?

m5p3nc3r commented 1 year ago

cargo outdated -d 1 now passes. I have added the changelog entry. Hopefully this is all good now :o)