search

rustonaut / vec1

Rust `Vec<T>` wrapper that gurantees to contain at least 1 element
Apache License 2.0
88 stars 15 forks source link

Use fully qualified path in macro #23

Closed little-dude closed 3 years ago

little-dude commented 3 years ago

Otherwise, users have to import SmallVec1 when using the smallvec1 macro.

Btw thanks a lot for the smallvec support 👍 Do you think it would be possible to make a release with it?

little-dude commented 3 years ago

Hello @rustonaut, would it be possible for you to take a look at this soon-ish ?

rustonaut commented 3 years ago

Omg, sorry. Due to some other things I did forget about it. Good that you pinged me.

On Wed, Mar 10, 2021, 09:37 Corentin Henry notifications@github.com wrote:

Hello @rustonaut https://github.com/rustonaut, would it be possible for you to take a look at this soon-ish ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rustonaut/vec1/pull/23#issuecomment-795087499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2HJEKAS2PK4SWXHCDZ6A3TC4VSXANCNFSM4YU5MUTA .

rustonaut commented 3 years ago

Merged, I also made a new version tag. But due to the large refactoring involved I want to add a few more tests before publishing the version, to make sure there had been no accidental changes of Vec1 (like accidentally dropping a method impl. when moving to the shared impl macro.).

little-dude commented 3 years ago

Thanks a lot @rustonaut !