rustonaut / vec1

Rust `Vec<T>` wrapper that gurantees to contain at least 1 element
Apache License 2.0
90 stars 15 forks source link

Reduce rust-version to 1.71.1 #34

Closed dahlbaek closed 5 months ago

dahlbaek commented 6 months ago

Only a minor change is needed in order to support rustc 1.71.1. Since 1.71.1 is the version of rust currently packaged by Debian trixie (https://packages.debian.org/testing/rustc), distro packagers and others using an older compiler will benefit if that version can be supported out of the box.

For reference, the extra as_slice simply follows the current implementation in the stdlib

https://github.com/rust-lang/rust/blob/d84b9037541f45dc2c52a41d723265af211c0497/library/alloc/src/vec/mod.rs#L3374-L3387

rustonaut commented 6 months ago

lgmt,

-------- Original Message -------- On May 20, 2024, 02:11, dahlbaek wrote:

Only a minor change is needed in order to support rustc 1.71.1. Since 1.71.1 is the version of rust currently packaged by Debian trixie, distro packagers will benefit if that version can be supported out of the box.

For reference, the extra as_slice simply follows the current implementation in the stdlib

https://github.com/rust-lang/rust/blob/d84b9037541f45dc2c52a41d723265af211c0497/library/alloc/src/vec/mod.rs#L3374-L3387


You can view, comment on, or merge this pull request online at:

https://github.com/rustonaut/vec1/pull/34

Commit Summary

  • 8cdae91 Reduce rust-version to 1.71.1

File Changes

(2 files)

Patch Links:

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

dahlbaek commented 5 months ago

Great! Let me know if there's anything I should do before it can be merged. I notice that I overlooked at reference to the rustc version in rust-toolchain.toml, though I'm not sure if you would actually want me to change that value :thinking:

rustonaut commented 5 months ago

new version was published