rustpq / pqcrypto

Rust Post-Quantum cryptography
226 stars 41 forks source link

PQClean: Update to latest master #19

Closed RW-sec closed 3 years ago

RW-sec commented 3 years ago

Hi Thom, this PR updates PQClean to latest master and makes the needed changes to the Rust wrappers. Please find below a short list of changes.

This PR also fixes issue #17 as I have added a note to the implementations.yaml. I have also added the compiler flag carry-less multiplication "pclmul" and "sse2" to the AVX2 config for HQC compilation. Should we summarize all compiler flags under AVX2 or should we create a separate flag for SSE2 and pclmul?

thomwiggers commented 3 years ago

Thanks for the update by the way, I've been neglecting these crates.

RW-sec commented 3 years ago

Hi Thom, thank you for your feedback. I updated CHANGELOG.md and increased the version numbers. Please check if they are as expected. The report for the bug is on its way. I have to thank you for providing this project.

RW-sec commented 3 years ago

I applied your changes and built and tested it with cargo.

thomwiggers commented 3 years ago

I'm running the release script now.

RW-sec commented 3 years ago

Great. I am looking forward for further updates. It was a pleasure to make this PR.