rustprooflabs / pgosm-flex

PgOSM Flex provides high quality OpenStreetMap datasets in PostGIS (Postgres) using the osm2pgsql Flex output.
MIT License
100 stars 20 forks source link

Road polygon `ref` missing comment #210

Closed rustprooflabs closed 2 years ago

rustprooflabs commented 2 years ago

What version of PgOSM Flex are you using?

Noticed in v0.3.3 data, verified still present in main branch.

What did you do exactly?

Using PgDD looking at ref column I noticed the osm.road_polygon is missing a description.

SELECT s_name, source_type, t_name, c_name, data_type, description
    FROM dd.columns
    WHERE c_name = 'ref'
         AND s_name = 'osm'
;
┌────────┬─────────────┬────────────────────────┬────────┬───────────┬─────────────────────────────────────────────┐
│ s_name │ source_type │         t_name         │ c_name │ data_type │                 description                 │
╞════════╪═════════════╪════════════════════════╪════════╪═══════════╪═════════════════════════════════════════════╡
│ osm    │ table       │ public_transport_line  │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ public_transport_point │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ public_transport_polyg…│ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │…on                     │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_line              │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_point             │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_polygon           │ ref    │ text      │ ¤                                           │
└────────┴─────────────┴────────────────────────┴────────┴───────────┴─────────────────────────────────────────────┘

To fix

Verified this is missing in /flex-config/sql/road.sql. Add the missing comment.

rustprooflabs commented 2 years ago

Closed via #213