search

rustprooflabs / pgosm-flex

PgOSM Flex provides high quality OpenStreetMap datasets in PostGIS (Postgres) using the osm2pgsql Flex output.
MIT License
101 stars 20 forks source link

Change default operation to NOT use `pg_dump` #266

Closed rustprooflabs closed 1 year ago

rustprooflabs commented 2 years ago

Details

:warning: Breaking Change Proposed :warning:

I expect the Experimental designation will be removed from --append --replication mode in the near(ish) future, either late 2022 or early 2023. I am considering making --append --replication the default recommendation. With that change, it would be nice to not have to always include --skip-dump if that's the recommended / most common method used. Being Pre 1.0, if this change is going to be made now is the time to do it.

Currently the default is to run pg_dump by default, and specify when you don't want it. Running pg_dump doesn't make much sense when using --append --replication. The purpose of the .sql is to load to your databases. With append this shouldn't be necessary for the majority of use cases.

The process to export the .sql file would use a new option --pg-dump.

Feedback welcome

If you have thoughts on this in either direction let me know. I'm not dedicated to making this change if it will cause a lot of friction with existing users. My main motivation for this is that I think users will appreciate being able to use --append --replication and that will gain traction.

rustprooflabs commented 2 years ago

Asking for feedback. https://mastodon.social/@rustprooflabs/109357178475099314 https://twitter.com/RustProofLabs/status/1593094106158628869

jacopofar commented 2 years ago

totally makes sense to me, besides it can always be executed with docker exec when needed

rustprooflabs commented 1 year ago

This change has been made, currently in the dev branch and :dev Docker image.