search

rustsec / advisory-db

Security advisory database for Rust crates published through crates.io
https://rustsec.org
Other
892 stars 342 forks source link

retain_mut is deprecated #1929

Open paolobarbolini opened 3 months ago

paolobarbolini commented 3 months ago

As described in the README, retain_mut has been deprecated with the release of Rust 1.61, which stabilized Vec::retain_mut and VecDeque::retain_mut.

I see this crate still makes peaks of 30k downloads a day, with Rust 1.61 having been released almost 2 years ago. Should an advisory be made for it?

paolobarbolini commented 3 months ago

Cc @upsuper

8573 commented 3 months ago

The crate's README says:

This crate has been deprecated. Rust 1.61 stabilized retain_mut for Vec and VecDeque, so you can use them directly. This crate is no longer maintained.

I don't think RustSec usually carries mere deprecation warnings, but the last sentence is more relevant.

upsuper commented 3 months ago

While I'm not sure how useful such an advisory would be, I'm not against issuing one. It is indeed unmaintained, but on the other hand, it is also very unlikely keeping the current implementation would have any security implication.