hello world: reinstall deps before npm run install

muxator commented 5 years ago

Without this pass, the subsequent npm run start would fail with:

ERROR in ./index.js
Module not found: Error: Can't resolve 'wasm-game-of-life' in '<basedir>/wasm-game-of-life/www'
 @ ./index.js 1:0-42 3:0-10
 @ ./bootstrap.js

✋ A similar PR may already be submitted! Please search 🔎 among the open pull requests before creating one.

Updating the Game of Life tutorial's code? Also send a PR to rustwasm/wasm_game_of_life!

Now that you've checked, it's time to create your PR. 📝 Thanks for submitting! 🙏

For more information, see the contributing guide. 👫

Summary

Explain the motivation for making this change. What existing problem does the pull request solve? 🤔

Fixes #___

lewixlabs commented 5 years ago

I'm agree 👍 npm install must be launched before npm run start

erewok commented 5 years ago

I was just coming here to offer this exact change. It tripped me up at first.

rustwasm / book

hello world: reinstall deps before npm run install #171

Summary